netdev - Re: [PATCH v2] tcp: tsq: restore minimal amount of queueing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <pan.2013.11.13.21.59.50.578858@googlemail.com>
Date:	Wed, 13 Nov 2013 22:59:50 +0100
From:	"Holger Hoffstaette" <holger.hoffstaette@...glemail.com>
To:	netdev@...r.kernel.org
Subject: Re: [PATCH v2] tcp: tsq: restore minimal amount of queueing

On Wed, 13 Nov 2013 22:18:12 +0100, Arnaud Ebalard wrote:

> Hi Eric,
> 
> Eric Dumazet <eric.dumazet@...il.com> writes:
> 
>> From: Eric Dumazet <edumazet@...gle.com>
>>
>> After commit c9eeec26e32e ("tcp: TSQ can use a dynamic limit"), several
>> users reported throughput regressions, notably on mvneta and wifi
>> adapters.
>>
>> 802.11 AMPDU requires a fair amount of queueing to be effective.
>>
>> This patch partially reverts the change done in tcp_write_xmit() so that
>> the minimal amount is sysctl_tcp_limit_output_bytes.
> 
> I just tested the fix on current linux tree with the same setup on which I
> observed the regression: it also fixes it on my side on my RN102. Thanks
> for the quick fix, Eric.

+1: fixes spastic NFS & Samba throughput since 3.12.0 with r8169 and e100e
for me as well. It's really not just broken/weird Wifi cards that are
affected by this.

Thanks!

-h


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html