netdev - Re: [PATCH iproute2] htb: support 64bit rates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1384352510.28458.105.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 13 Nov 2013 06:21:50 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Yang Yingliang <yangyingliang@...wei.com>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2] htb: support 64bit rates

On Wed, 2013-11-13 at 17:11 +0800, Yang Yingliang wrote:
> > -	if (!buffer) buffer = opt.rate.rate / get_hz() + mtu;
> > -	if (!cbuffer) cbuffer = opt.ceil.rate / get_hz() + mtu;
> > +	if (!buffer)
> > +		buffer = rate64 / get_hz() + mtu;
> > +	if (!cbuffer)
> > +		cbuffer = ceil64 / get_hz() + mtu;
> 
> Hi,
> It may overflow here if rate64 and mtu are big enough.

Not really.

get_hz() on current kernels is really huge : 1000000000




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html