netdev - Re: [PATCH] net: ethernet: ti/cpsw: do not crash on single-MAC machines during resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5284C87A.60404@gmail.com>
Date:	Thu, 14 Nov 2013 13:56:26 +0100
From:	Daniel Mack <zonque@...il.com>
To:	Mugunthan V N <mugunthanvnm@...com>, netdev@...r.kernel.org
CC:	davem@...emloft.net
Subject: Re: [PATCH] net: ethernet: ti/cpsw: do not crash on single-MAC machines
 during resume

On 11/14/2013 01:45 PM, Mugunthan V N wrote:
> On Wednesday 13 November 2013 06:23 PM, Daniel Mack wrote:
>> To prevent Oopses, cpsw_suspend() should only soft-reset sliver 1
>> on dual MAC enabled machines.
>>
>> Signed-off-by: Daniel Mack <zonque@...il.com>
>> ---
>>  drivers/net/ethernet/ti/cpsw.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
>> index edd3e79..702b063 100644
>> --- a/drivers/net/ethernet/ti/cpsw.c
>> +++ b/drivers/net/ethernet/ti/cpsw.c
>> @@ -2173,8 +2173,11 @@ static int cpsw_suspend(struct device *dev)
>>  
>>  	if (netif_running(ndev))
>>  		cpsw_ndo_stop(ndev);
>> +
>>  	soft_reset("sliver 0", &priv->slaves[0].sliver->soft_reset);
>> -	soft_reset("sliver 1", &priv->slaves[1].sliver->soft_reset);
>> +	if (priv->data.dual_emac)
>> +		soft_reset("sliver 1", &priv->slaves[1].sliver->soft_reset);
> 
> Is this tested on a system with both ports in switch mode?

Nope. I got an Ooops when I tried to suspend a machine that has only one
slave configured in DTS.

> I don't think this will not work with both ports in switch mode.

Why? Isn't priv->data.dual_emac in that case? The same condition is
checked for in cpsw_remove().


Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html