netdev - RE: [PATCH v2 1/1] net:fec: fix WARNING caused by lack of calls to dma_mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 14 Nov 2013 01:47:16 +0000
From:	Fugang Duan <fugang.duan@...escale.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Frank Li <Frank.Li@...escale.com>
Subject: RE: [PATCH v2 1/1] net:fec: fix WARNING caused by lack of calls to
 dma_mapping_error()

From: Ben Hutchings [mailto:bhutchings@...arflare.com]
Data: Thursday, November 14, 2013 5:27 AM

>To: Duan Fugang-B38611
>Cc: davem@...emloft.net; netdev@...r.kernel.org; Li Frank-B20596
>Subject: Re: [PATCH v2 1/1] net:fec: fix WARNING caused by lack of calls to
>dma_mapping_error()
>
>On Wed, 2013-11-13 at 11:04 +0800, Fugang Duan wrote:
>[...]
>> =============================================
>> V2: add net_ratelimit() to limit map err message.
>>     use dma_sync_single_for_cpu() instead of dma_map_single().
>>     fix the issue that pass DMA addresses to __va() to get virture address.
>> V1: initial send
>> =============================================
>>
>> Signed-off-by: Fugang Duan <B38611@...escale.com>
>> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
>[...]
>
>No that's not how it works.  If I were to thoroughly review this (but I haven't,
>and I don't have time to) then I might say 'Reviewed-by: Ben Hutchings' which
>you could then add to the patch if re-posting it.
>Signed-off-by means something different and you must never add it on behalf of
>someone else.
>
>Ben.

You had supported many ideas for the patch V2, so add you to Signed-off.
Ok, I change it to "Reveiewed-by" and resend the patch.

Thanks,
Andy
>
>--
>Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's
>the marketing department's job.
>They asked us to note that Solarflare product names are trademarked.