netdev - Re: [PATCH] net-tcp: fix panic in tcp_fastopen_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131114175514.GA9630@redhat.com>
Date:	Thu, 14 Nov 2013 12:55:14 -0500
From:	Dave Jones <davej@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH] net-tcp: fix panic in tcp_fastopen_cache_set()

On Wed, Nov 13, 2013 at 03:00:46PM -0800, Eric Dumazet wrote:
 > From: Eric Dumazet <edumazet@...gle.com>
 > 
 > We had some reports of crashes using TCP fastopen, and Dave Jones
 > gave a nice stack trace pointing to the error.
 > 
 > Issue is that tcp_get_metrics() should not be called with a NULL dst
 > 
 > Fixes: 1fe4c481ba637 ("net-tcp: Fast Open client - cookie cache")
 > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
 > Reported-by: Dave Jones <davej@...hat.com>
 > Cc: Yuchung Cheng <ycheng@...gle.com>

I let this run overnight, looks good.

Tested-by: Dave Jones <davej@...oraproject.org>

thanks Eric.
 
	Dave
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html