netdev - Re: [PATCH] net-tcp: fix panic in tcp_fastopen_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1384462403.13941.41.camel@jlt4.sipsolutions.net>
Date:	Thu, 14 Nov 2013 21:53:23 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Dave Jones <davej@...hat.com>, David Miller <davem@...emloft.net>,
	netdev@...r.kernel.org, Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH] net-tcp: fix panic in tcp_fastopen_cache_set()

On Thu, 2013-11-14 at 11:38 -0800, Eric Dumazet wrote:

> > > Doesn't that __sk_dst_get() have to go inside the rcu_read_lock()?
> > > 
> > > Then again, I guess we hold the socket. Still looks a bit weird to be
> > > moving it out.
> > 
> > Yep, in fact this rcu_read_lock() is not needed. I'll send a v2.
> 
> I take it back.
> 
> the rcu_read_lock() protects the tcp_get_metrics(), not the
> __sk_dst_get(sk)
> 
> So the patch is correct, unless you disagree of course ;)

Heh. I have no idea, it just seemed a little odd on first look given
that __sk_dst_get() *can* actually use RCU protection. :)

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html