netdev - Re: [PATCH] pkt_sched: fq: change classification of control packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131114.171659.748664517209376981.davem@davemloft.net>
Date:	Thu, 14 Nov 2013 17:16:59 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, maze@...gle.com, willemb@...gle.com,
	ycheng@...gle.com, stephen@...workplumber.org
Subject: Re: [PATCH] pkt_sched: fq: change classification of control packets

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 14 Nov 2013 08:50:43 -0800

> From: Maciej Żenczykowski <maze@...gle.com>
> 
> Initial sch_fq implementation copied code from pfifo_fast to classify
> a packet as a high prio packet.
> 
> This clashes with setups using PRIO with say 7 bands, as one of the
> band could be incorrectly (mis)classified by FQ.
> 
> Packets would be queued in the 'internal' queue, and no pacing ever
> happen for this special queue.
> 
> Fixes: afe4fd062416 ("pkt_sched: fq: Fair Queue packet scheduler")
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html