netdev - Re: [PATCH net 0/3] bridge: Fix undesirable behavior related to vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52843FFE.7070202@redhat.com>
Date:	Wed, 13 Nov 2013 22:14:06 -0500
From:	Vlad Yasevich <vyasevic@...hat.com>
To:	Toshiaki Makita <makita.toshiaki@....ntt.co.jp>,
	"David S . Miller" <davem@...emloft.net>,
	Stephen Hemminger <stephen@...workplumber.org>,
	netdev@...r.kernel.org
Subject: Re: [PATCH net 0/3] bridge: Fix undesirable behavior related to vlan

On 11/13/2013 03:26 AM, Toshiaki Makita wrote:
> There seem to be some problems around vlan code.
>
> - Unexpectedly filter vlan by NIC.
> - Not correctly decrement refcount of vlan_vid_info.
> - Memory leak when deleting a bridge with vlan_info allocated.
>
> This is a patch series to fix these issues.
>
> Toshiaki Makita (3):
>    bridge: Use vlan_vid_[add/del] instead of direct
>      ndo_vlan_rx_[add/kill]_vid calls
>    bridge: Call vlan_vid_del for all vids at nbp_vlan_flush
>    bridge: Fix memory leak when deleting bridge with vlan filtering
>      enabled
>

These all look good to me.  Thanks you.

Acked-by: Vlad Yasevich <vyasevic@...hat.com>

-vlad

>   net/bridge/br_if.c   |  1 +
>   net/bridge/br_vlan.c | 24 ++++++++++--------------
>   2 files changed, 11 insertions(+), 14 deletions(-)
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html