netdev - Re: [RFC][PATCH 0/3] net_tstamp: Add SIOCGHWTSTAMP ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131114.015051.400187844893744601.davem@davemloft.net>
Date:	Thu, 14 Nov 2013 01:50:51 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	richardcochran@...il.com, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com
Subject: Re: [RFC][PATCH 0/3] net_tstamp: Add SIOCGHWTSTAMP ioctl

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 14 Nov 2013 02:37:15 +0000

> SIOCSHWTSTAMP returns the real configuration to the application
> using it, but there is currently no way for any other
> application to find out the configuration non-destructively.
> 
> This series adds a new ioctl with the obvious name which just reads the
> configuration, and an example implementation for the sfc driver.
> 
> This information could alternately be added to struct ethtool_ts_info
> returned by the ethtool ETHTOOL_GET_TS_INFO command, although that
> wouldn't be very symmetric.  There would also be a problem of how to
> indicate whether this extra information is present, given that all
> fields of hwtstamp_config can validly be 0.

No objections to the new ioctl, but you absolutely need to implement
the appropriate compat ioctl handler in net/socket.c just as we have
one for the existing SIOCSHWTSTAMP.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html