netdev - Re: [PATCH v2 net] core/dev: do not ignore dmac in dev_forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131114.024041.1374645290667127512.davem@davemloft.net>
Date:	Thu, 14 Nov 2013 02:40:41 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ast@...mgrid.com
Cc:	edumazet@...gle.com, netdev@...r.kernel.org,
	yamahatanetdev@...il.com, zenczykowski@...il.com,
	nicolas.dichtel@...nd.com
Subject: Re: [PATCH v2 net] core/dev: do not ignore dmac in
 dev_forward_skb()

From: Alexei Starovoitov <ast@...mgrid.com>
Date: Tue, 12 Nov 2013 14:39:13 -0800

> commit 06a23fe31ca3
> ("core/dev: set pkt_type after eth_type_trans() in dev_forward_skb()")
> and refactoring 64261f230a91
> ("dev: move skb_scrub_packet() after eth_type_trans()")
> 
> are forcing pkt_type to be PACKET_HOST when skb traverses veth.
> 
> which means that ip forwarding will kick in inside netns
> even if skb->eth->h_dest != dev->dev_addr
> 
> Fix order of eth_type_trans() and skb_scrub_packet() in dev_forward_skb()
> and in ip_tunnel_rcv()
> 
> Fixes: 06a23fe31ca3 ("core/dev: set pkt_type after eth_type_trans() in dev_forward_skb()")
> CC: Isaku Yamahata <yamahatanetdev@...il.com>
> CC: Maciej Zenczykowski <zenczykowski@...il.com>
> CC: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> Signed-off-by: Alexei Starovoitov <ast@...mgrid.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html