netdev - Re: [PATCH net 3/6] pch_gbe: Validate hwtstamp_config completely before applying it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131114.031743.441890100175989214.davem@davemloft.net>
Date:	Thu, 14 Nov 2013 03:17:43 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	richardcochran@...il.com
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH net 3/6] pch_gbe: Validate hwtstamp_config completely
 before applying it

From: Richard Cochran <richardcochran@...il.com>
Date: Thu, 14 Nov 2013 08:21:37 +0100

> On Thu, Nov 14, 2013 at 12:42:50AM +0000, Ben Hutchings wrote:
>> @@ -284,6 +276,8 @@ static int hwtstamp_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd)
>>  		return -ERANGE;
>>  	}
>>  
>> +	adapter->hwts_tx_en = cfg.tx_type == HWTSTAMP_TX_ON;
>> +
> 
> But now there is no way to turn transmit time stamping off?

He's assigning a boolean, the result of the test:

	cfg.tx_type == HWTSTAMP_TX_ON

to hwts_tx_en, he's not assigning HWTSTAMP_TX_ON to it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html