netdev - Re: [PATCH] net: Do not include padding in TCP GRO checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131114.230821.139211038449295349.davem@davemloft.net>
Date:	Thu, 14 Nov 2013 23:08:21 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	alexander.h.duyck@...el.com
Cc:	netdev@...r.kernel.org, edumazet@...gle.com,
	herbert@...dor.apana.org
Subject: Re: [PATCH] net: Do not include padding in TCP GRO checksum

From: Alexander Duyck <alexander.h.duyck@...el.com>
Date: Thu, 14 Nov 2013 17:18:18 -0800

> I haven't had a chance to test this much yet and I am not that familiar

As Eric mentioned, unless you tested on big endian, chances are you
didn't test this at all. :-)

You're accessing the IPv4/IPv6 length fields without converting it
to CPU endian.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html