netdev - Re: [PATCH net v4] bonding: add ip checks when store ip target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131115.174457.1747641547874304346.davem@davemloft.net>
Date:	Fri, 15 Nov 2013 17:44:57 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
Cc:	fubar@...ibm.com, andy@...yhouse.net, nikolay@...hat.com,
	vfalico@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v4] bonding: add ip checks when store ip target

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Fri, 15 Nov 2013 09:58:58 +0800

> From 513509eecdee98d72668219aead9784d56dbad0f Mon Sep 17 00:00:00 2001
> From: Wang Weidong <wangweidong1@...wei.com>
> Date: Fri, 15 Nov 2013 10:34:30 -0500
> Subject: [PATCH] bonding: add ip checks when store ip target
> 
> I met a Bug when I add ip target with the wrong ip address:
> 
> echo +500.500.500.500 > /sys/class/net/bond0/bonding/arp_ip_target
> 
> the wrong ip address will transfor to 245.245.245.244 and add
> to the ip target success, it is uncorrect, so I add checks to avoid
> adding wrong address.
> 
> The in4_pton() will set wrong ip address to 0.0.0.0, it will return by
> the next check and will not add to ip target.
> 
> v2
> According Veaceslav's opinion, simplify the code.
> 
> v3
> According Veaceslav's opinion, add broadcast check and make a micro
> definition to package it.
> 
> v4
> Solve the problem of the format which David point out.
> 
> Suggested-by: Veaceslav Falico <vfalico@...hat.com>
> Suggested-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html