[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <52863382.2060309@mojatatu.com>
Date: Fri, 15 Nov 2013 09:45:22 -0500
From: Jamal Hadi Salim <jhs@...atatu.com>
To: Johannes Berg <johannes@...solutions.net>,
David Miller <davem@...emloft.net>
CC: netdev@...r.kernel.org, linux-wimax@...el.com,
bsingharora@...il.com, netfilter-devel@...r.kernel.org,
alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com
Subject: Re: [PATCH 0/9] genetlink: reduce ops size and complexity (v2)
Are we killing APIs that are already used?
At least that patches that Dave sucked in do. Out of tree
users dont matter?
cheers,
jamal
On 11/15/13 08:23, Johannes Berg wrote:
> On Fri, 2013-11-15 at 14:18 +0100, Johannes Berg wrote:
>
>> I've been eyeing the multicast groups as well
>
> Of course, there are also *much* fewer mcast groups, so the saving isn't
> nearly as big. But we still have some oddball code to register them all,
> basically
>
> err = register_mc_group();
> if (err)
> goto unregister_family;
>
> (since we have to register the family first, afaict)
>
> sometimes a few of those back to back, and it'd be nicer on the users if
> that just went away and was
>
> family.mcast_groups = my_groups;
> family.n_mcast_groups = ARRAY_SIZE(my_groups);
> family.ops = my_ops;
> family.n_ops = ARRAY_SIZE(my_ops);
> return genl_register_family(&family);
>
> since nobody uses them dynamically anyway, afaict.
>
> johannes
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists