netdev - Re: [PATCH 1/2] net: ipv6: af_inet6: Fix warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5287B800.40201@gmail.com>
Date:	Sat, 16 Nov 2013 13:22:56 -0500
From:	Vlad Yasevich <vyasevich@...il.com>
To:	Fabio Estevam <festevam@...il.com>, davem@...emloft.net
CC:	netdev@...r.kernel.org, Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH 1/2] net: ipv6: af_inet6: Fix warning when CONFIG_SYSCTL=n

On 11/16/2013 01:05 PM, Vlad Yasevich wrote:
> On 11/15/2013 09:52 PM, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@...escale.com>
>>
>> When CONFIG_SYSCTL=n the following build warning happens:
>>
>> net/ipv6/af_inet6.c:710:13: warning: 'ipv6_packet_cleanup' defined but not used [-Wunused-function]
>>
>> ipv6_packet_cleanup() is only used when CONFIG_SYSCTL=y, so protect its 
>> definition with an'ifdef CONFIG_SYSCTL'.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
>> ---
>>  net/ipv6/af_inet6.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
>> index ff75313..e4ad65c 100644
>> --- a/net/ipv6/af_inet6.c
>> +++ b/net/ipv6/af_inet6.c
>> @@ -707,10 +707,12 @@ static int __init ipv6_packet_init(void)
>>  	return 0;
>>  }
>>  
>> +#ifdef CONFIG_SYSCTL
>>  static void ipv6_packet_cleanup(void)
>>  {
>>  	dev_remove_pack(&ipv6_packet_type);
>>  }
>> +#endif
>>  
>>  static int __net_init ipv6_init_mibs(struct net *net)
>>  {
>>
> 
> NACK.  ipv6_packet_init and ipv6_packet_cleanup should in no way depend
> on sysctl.
> 
> -vlad
> 

It actually appears a bit worse then that.  Looks like the inet6_init()
error were a bit messed up after the introduction of ping socket support.

-vlad


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html