netdev - Re: [PATCH net] xen-netfront: fix missing rx_refill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131118.135735.467426814194053418.davem@davemloft.net>
Date:	Mon, 18 Nov 2013 13:57:35 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	majieyue@...il.com
Cc:	netdev@...r.kernel.org, konrad.wilk@...cle.com,
	wei.liu2@...rix.com, jieyue.majy@...baba-inc.com,
	david.vrabel@...rix.com, annie.li@...cle.com,
	boris.ostrovsky@...cle.com, xen-devel@...ts.xenproject.org
Subject: Re: [PATCH net] xen-netfront: fix missing rx_refill_timer when
 allocate memory failed

From: Ma JieYue <majieyue@...il.com>
Date: Fri, 15 Nov 2013 12:26:13 +0800

> From: Ma JieYue <jieyue.majy@...baba-inc.com>
> 
> There was a bug in xennet_alloc_rx_buffers, when allocating page or
> sk_buff failed, and at the same time rx_batch queue not empty,
> the rx_refill_timer timer won't be scheduled. If finally the remaining
> request buffers in rx ring less than what backend driver expected,
> the backend driver would think of rx ring as full and start dropping packets.
> In such situation, there is no way for the netfront driver to recover
> automatically, so that the device can not work properly.
> 
> The patch fixes the problem by always scheduling rx_refill_timer timer when
> alloc_page or __netdev_alloc_skb fails, no matter whether rx_batch queue is
> empty or not. It ensures that the rx ring request buffers will finally meet
> the backend needs.
> 
> Signed-off-by: Ma JieYue <jieyue.majy@...baba-inc.com>

Looks good, applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html