netdev - Re: [PATCH 4/4] net, virtio_net: replace the magic value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131118101517.GA3559@redhat.com>
Date:	Mon, 18 Nov 2013 12:15:17 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Zhi Yong Wu <zwu.kernel@...il.com>
Cc:	netdev@...r.kernel.org, QEMU Developers <qemu-devel@...gnu.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>,
	linux-kernel mlist <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] net, virtio_net: replace the magic value

On Mon, Nov 18, 2013 at 06:07:45PM +0800, Zhi Yong Wu wrote:
> On Mon, Nov 18, 2013 at 5:50 PM, Michael S. Tsirkin <mst@...hat.com> wrote:
> > On Mon, Nov 18, 2013 at 04:46:20PM +0800, Zhi Yong Wu wrote:
> >> From: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
> >>
> >> It is more appropriate to use # of queue pairs currently used by
> >> the driver instead of a magic value.
> >>
> >> Signed-off-by: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
> >
> > I don't mind, but driver should be submitted separately
> > from qemu patches. As it is only patch 4/4 made it to netdev.
> ok, i will sent v2. By the way, can you help take a look at the
> following patches?

Will do.

> Maybe i can send their v2 together.

Please don't, these seem to be completely unrelated.

> [PATCH 1/3] vhost: remove the dead branch
> [PATCH 2/3] vhost: adjust vhost_dev_init() to be void
> [PATCH 3/3] vhost: fix the wrong log descriptions
> 
> 
> >
> >> ---
> >>  drivers/net/virtio_net.c |    4 ++--
> >>  1 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> >> index cdc7c90..e0cb2d1 100644
> >> --- a/drivers/net/virtio_net.c
> >> +++ b/drivers/net/virtio_net.c
> >> @@ -1619,8 +1619,8 @@ static int virtnet_probe(struct virtio_device *vdev)
> >>       if (err)
> >>               goto free_stats;
> >>
> >> -     netif_set_real_num_tx_queues(dev, 1);
> >> -     netif_set_real_num_rx_queues(dev, 1);
> >> +     netif_set_real_num_tx_queues(dev, vi->curr_queue_pairs);
> >> +     netif_set_real_num_rx_queues(dev, vi->curr_queue_pairs);
> >>
> >>       err = register_netdev(dev);
> >>       if (err) {
> >> --
> >> 1.7.6.5
> >>
> 
> 
> 
> -- 
> Regards,
> 
> Zhi Yong Wu
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html