netdev - Re: [PATCH 3/3] vhost: fix the wrong log descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEH94LgTBWqG6At_rbYLkEEp9RSn+RiJPwT7uKzdcu_+7cKhDw@mail.gmail.com>
Date:	Mon, 18 Nov 2013 21:12:22 +0800
From:	Zhi Yong Wu <zwu.kernel@...il.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	netdev@...r.kernel.org, Rusty Russell <rusty@...tcorp.com.au>,
	Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
Subject: Re: [PATCH 3/3] vhost: fix the wrong log descriptions

On Mon, Nov 18, 2013 at 6:18 PM, Michael S. Tsirkin <mst@...hat.com> wrote:
> On Mon, Nov 18, 2013 at 11:19:23AM +0800, Zhi Yong Wu wrote:
>> From: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
>>
>> Signed-off-by: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
>
> This one does not make sense to me.
> Heads in avail ring are heads which according to Guest are available by
> definition.
ok, please ignore this patch
>
>
>> ---
>>  drivers/vhost/vhost.c  |    2 +-
>>  drivers/vhost/vringh.c |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
>> index 78987e4..568d20f 100644
>> --- a/drivers/vhost/vhost.c
>> +++ b/drivers/vhost/vhost.c
>> @@ -1241,7 +1241,7 @@ int vhost_get_vq_desc(struct vhost_dev *dev, struct vhost_virtqueue *vq,
>>
>>       /* If their number is silly, that's an error. */
>>       if (unlikely(head >= vq->num)) {
>> -             vq_err(vq, "Guest says index %u > %u is available",
>> +             vq_err(vq, "Guest says index %u > %u is unavailable",
>>                      head, vq->num);
>>               return -EINVAL;
>>       }
>> diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c
>> index 5174eba..86ef6c4 100644
>> --- a/drivers/vhost/vringh.c
>> +++ b/drivers/vhost/vringh.c
>> @@ -57,7 +57,7 @@ static inline int __vringh_get_head(const struct vringh *vrh,
>>       }
>>
>>       if (head >= vrh->vring.num) {
>> -             vringh_bad("Guest says index %u > %u is available",
>> +             vringh_bad("Guest says index %u > %u is unavailable",
>>                          head, vrh->vring.num);
>>               return -EINVAL;
>>       }
>> --
>> 1.7.6.5



-- 
Regards,

Zhi Yong Wu
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html