netdev - Re: [PATCH 2/2] ipv6: use sk_v6_copy_addrs when memcpy struct ipv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <528AEC9A.5050100@huawei.com>
Date:	Tue, 19 Nov 2013 12:44:10 +0800
From:	wangweidong <wangweidong1@...wei.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	<davem@...emloft.net>, <gerrit@....abdn.ac.uk>,
	<kuznet@....inr.ac.ru>, <jmorris@...ei.org>,
	<yoshfuji@...ux-ipv6.org>, <kaber@...sh.net>,
	<vyasevich@...il.com>, <nhorman@...driver.com>,
	<dccp@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-sctp@...r.kernel.org>, <dingtianhong@...wei.com>
Subject: Re: [PATCH 2/2] ipv6: use sk_v6_copy_addrs when memcpy struct ipv6_pinfo

On 2013/11/19 12:00, Eric Dumazet wrote:
> On Mon, 2013-11-18 at 19:58 -0800, Eric Dumazet wrote:
> 
>> But sctp is not tcp ;)
>>
>> sctp_copy_sock() is doing some clever/partial copy of the socket, so
>> please fix it ;)
>>
>> No idea why it's not doing the normal copy of the socket.
> 
> BTW, not doing the full copy means for example that SO_MAX_PACING_RATE
> is broken for SCTP.
> 
> 
>

The dccp will copy the geniric socket, too. And You mean to say that only
add the copies in sctp_copy_sock(). 

Thanks. 
> 
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html