| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B7432@saturn3.aculab.com> Date: Tue, 19 Nov 2013 12:08:06 -0000 From: "David Laight" <David.Laight@...LAB.COM> To: "Steffen Klassert" <steffen.klassert@...unet.com>, "David Miller" <davem@...emloft.net> Cc: <yoshfuji@...ux-ipv6.org>, <netdev@...r.kernel.org> Subject: RE: [PATCH net] neigh: Force garbage collection if an entry is deleted administratively > > My conclusion is that the management of the state is the problem. > > Specifically, if we invalidate an entry then we should remove it's > > visisbility. This means the table should operate by unhashing the > > entry unconditionally during such operations. > > > > If some stray references exist, that's fine, the entity holding the > > reference will perform the final neigh cleanup at release time. > > > > Does this make sense to you? > > Yes, makes sense :-) Isn't it enough to act as if the entry were not in the hash tables. So an attempt to add such an entry wouldn't fail. I've not looked at these code paths, but it can easily be that when the entry is invalidated the hash table isn't (and can't easily be) locked - just having the entry locked may make it difficult. Whereas the code path to add an entry can easily delete old entries. David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists