netdev - Re: [PATCH] genetlink: fix genlmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131121.131809.935111586164423904.davem@davemloft.net>
Date:	Thu, 21 Nov 2013 13:18:09 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	johannes@...solutions.net
Cc:	netdev@...r.kernel.org, johannes.berg@...el.com
Subject: Re: [PATCH] genetlink: fix genlmsg_multicast() bug

From: Johannes Berg <johannes@...solutions.net>
Date: Thu, 21 Nov 2013 18:17:04 +0100

> From: Johannes Berg <johannes.berg@...el.com>
> 
> Unfortunately, I introduced a tremendously stupid bug into
> genlmsg_multicast() when doing all those multicast group
> changes: it adjusts the group number, but then passes it
> to genlmsg_multicast_netns() which does that again.
> 
> Somehow, my tests failed to catch this, so add a warning
> into genlmsg_multicast_netns() and remove the offending
> group ID adjustment.
> 
> Also add a warning to the similar code in other functions
> so people who misuse them are more loudly warned.
> 
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html