netdev - Re: [PATCH v2] gso: handle new frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131121.141250.1850041110555494669.davem@davemloft.net>
Date:	Thu, 21 Nov 2013 14:12:50 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	herbert@...dor.apana.org.au, linux@...elenboom.it,
	edumazet@...gle.com, romieu@...zoreil.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] gso: handle new frag_list of frags GRO packets

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 21 Nov 2013 11:10:04 -0800

> From: Herbert Xu <herbert@...dor.apana.org.au>
> 
> Recently GRO started generating packets with frag_lists of frags.
> This was not handled by GSO, thus leading to a crash.
> 
> Thankfully these packets are of a regular form and are easy to
> handle.  This patch handles them in two ways.  For completely
> non-linear frag_list entries, we simply continue to iterate over
> the frag_list frags once we exhaust the normal frags.  For frag_list
> entries with linear parts, we call pskb_trim on the first part
> of the frag_list skb, and then process the rest of the frags in
> the usual way.
> 
> This patch also kills a chunk of dead frag_list code that has
> obviously never ever been run since it ends up generating a bogus
> GSO-segmented packet with a frag_list entry.
> 
> Future work is planned to split super big packets into TSO
> ones.
> 
> Fixes: 8a29111c7ca6 ("net: gro: allow to build full sized skb")
> Reported-by: Christoph Paasch <christoph.paasch@...ouvain.be>
> Reported-by: Jerry Chu <hkchu@...gle.com>
> Reported-by: Sander Eikelenboom <linux@...elenboom.it>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Tested-by: Sander Eikelenboom <linux@...elenboom.it>
> Tested-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for 3.12-stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html