netdev - Re: [PATCH net-next 7/8] openvswitch: Drop user features if old user space attempted to create datapath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131121222047.GA14252@casper.infradead.org>
Date:	Thu, 21 Nov 2013 22:20:47 +0000
From:	Thomas Graf <tgraf@...g.ch>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	jesse@...ira.com, davem@...emloft.net, dev@...nvswitch.org,
	netdev@...r.kernel.org, dborkman@...hat.com, ffusco@...hat.com,
	fleitner@...hat.com, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 7/8] openvswitch: Drop user features if old user
 space attempted to create datapath

On 11/21/13 at 06:23pm, Ben Hutchings wrote:
> On Thu, 2013-11-21 at 19:13 +0100, Thomas Graf wrote:
> > +
> > +/**
> > + * V2:
> 
> This is not kernel-doc format so don't use '/**'.

I was hoping kernel-doc would pick it up but it doesn't.
I'll convert it.

> > +		if (info->genlhdr->version < OVS_DP_VER_FEATURES) {
> > +			WARN_ONCE(dp->user_features, "Dropping previously "
> > +				  "announced user features");
> 
> Log messages shouldn't be split like this as it makes them harder to
> find.  There should also be a newline at the end of the message.

Right, I'll fix this up. We seem to have many of these unfixed.

Jesse, do you want a full respin or just a v2 of this patch?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html