netdev - Re: [net-next 12/13] bna: Firmware Patch Simplification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Nov 2013 22:26:20 -0800
From:	Joe Perches <joe@...ches.com>
To:	Rasesh Mody <rmody@...cade.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	adapter_linux_open_src_team@...cade.COM
Subject: Re: [net-next 12/13] bna: Firmware Patch Simplification

On Wed, 2013-11-20 at 21:54 -0800, Rasesh Mody wrote:
> This patch includes change to enable firmware patch simplication feature.
> This feature is targeted to address the requirement to have independent patch
> release for firmware. Prior to the 3.2.3.0 firmware, releasing a patch fix for
> firmware would require changes to bna driver, to use new firmware images.
> However with these changes, if the new firmware is flashed on to the Adapter,
> the driver will use the new firmware after checking the patch release byte in
> the firmware version.

Please run your patches through checkpatch --strict

> +/* flash command register data structure */
> +union bfa_flash_cmd_reg {
> +	struct {
> +#ifdef __BIGENDIAN

__BIG_ENDIAN?

> +/* flash device status register data structure */
> +union bfa_flash_dev_status_reg {
> +	struct {
> +#ifdef __BIGENDIAN

__BIG_ENDIAN here too?

> +/* flash address register data structure */
> +union bfa_flash_addr_reg {
> +	struct {
> +#ifdef __BIGENDIAN

and here



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html