netdev - Re: [PATCH] net: rework recvmsg handler msg_name and msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131121010729.GB32587@order.stressinduktion.org>
Date:	Thu, 21 Nov 2013 02:07:29 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, eric.dumazet@...il.com
Subject: Re: [PATCH] net: rework recvmsg handler msg_name and msg_namelen logic

On Wed, Nov 20, 2013 at 05:02:40PM -0800, Joe Perches wrote:
> On Thu, 2013-11-21 at 01:38 +0100, Hannes Frederic Sowa wrote:
> > This patch now always passes msg->msg_namelen as 0. recvmsg handlers must
> > set msg_namelen to the proper size <= sizeof(struct sockaddr_storage)
> > to return msg_name to the user.
> []
> > This change does not alter the user visible error logic as we ignore
> > msg_namelen as long as msg_name is NULL.
> > 
> > Also remove two unnecessary curly brackets in ___sys_recvmsg and change
> > comments to netdev style.
> 
> Perhaps take the opportunity to remove the unnecessary casts of
> struct msghdr.msg_name as it's a void *.
> 
> And there's one other oddity about setting a known NULL to NULL.
> 
> Maybe fix in a follow-on patch?

No, that is easily done in this one. I'll send a v2 shortly.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html