netdev - Re: [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772B under ChromeOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcase25NosVHA74OLnviJj7nU_2Rxki_hvi8bOwznDuWGg@mail.gmail.com>
Date:	Thu, 21 Nov 2013 17:58:10 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Grant Grundler <grundler@...gle.com>
Cc:	David Miller <davem@...emloft.net>,
	Freddy Xin <freddy@...x.com.tw>,
	netdev <netdev@...r.kernel.org>, linux-usb@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, davemloft@...emloft.net,
	ASIX Louis [蘇威陸] <louis@...x.com.tw>,
	Allan Chou <allan@...x.com.tw>,
	Daniel_ASIX <daniel@...x.com.tw>
Subject: Re: [PATCH 1/1] Workaround for Suspend/Resume issue of AX88772B under ChromeOS

2013/11/21 Grant Grundler <grundler@...gle.com>:
> On Wed, Nov 20, 2013 at 11:32 AM, Grant Grundler <grundler@...gle.com> wrote:
>> Seems like this should be part of usbnet_resume code based on whether
>> the driver provides mdio_write hook (most USBNET drivers do).
>
> Just to be clear: I don't think this is feasible for the now obvious
> reason that not all device lose phy stat on resume. :/
>
> Freddy sent me a patch that saves/restores MII_ADVERTISE and MII_BMCR
> registers. Testing that now and he'll post if that all works out.

That should be enough to ensure the PHY is put back into a consistent
state. So long as you are suspending/resuming from a configuration
where autoneg was enabled, I would not expect anything bad to happen.
If the link was forced, that is a different story.

One way to make sure this work properly without driver-specific code
is to include that functionality into the PHY library. As far as I can
see it the asix drivers do not use it but implement the old-style
mii_bus interface so that would be a first step.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html