netdev - Re: [PATCH linux-next] hisax: disable build for big-endian arm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hli0ghjps.wl%tiwai@suse.de>
Date:	Fri, 22 Nov 2013 10:25:03 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Vincent Stehlé <vincent.stehle@...oste.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux-Next <linux-next@...r.kernel.org>,
	Karsten Keil <isdn@...ux-pingi.de>
Subject: Re: [PATCH linux-next] hisax: disable build for big-endian arm

At Fri, 22 Nov 2013 10:19:07 +0100,
Geert Uytterhoeven wrote:
> 
> On Fri, Nov 22, 2013 at 8:29 AM, Takashi Iwai <tiwai@...e.de> wrote:
> >>  config HISAX_TELESPCI
> >>       bool "Teles PCI"
> >> -     depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
> >> +     depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || (ARM && !CPU_LITTLE_ENDIAN)))
> >
> > Isn't it a bit better to exclude CPU_LITTLE_ENDIAN globally?
> >
> >         depends on PCI && CPU_LITTLE_ENDIAN && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA || ARM))
> 
> CPU_LITTLE_ENDIAN is not defined on all little endian platforms,
> only on those that can support both big and little endian.

Ah, a good point.

> But I guess it wouldn't hurt to move CPU_{BIG,LITTLE}_ENDIAN to
> a common Kconfig file.

Yeah, this make life easier.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html