netdev - Re: [ovs-dev] [PATCH openvswitch] linux: Signal datapath that unaligned Netlink message can be received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <528F7B2D.1060105@cogentembedded.com>
Date:	Fri, 22 Nov 2013 19:41:33 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Ben Pfaff <blp@...ira.com>
CC:	Thomas Graf <tgraf@...hat.com>, jesse@...ira.com,
	dev@...nvswitch.org, netdev@...r.kernel.org
Subject: Re: [ovs-dev] [PATCH openvswitch] linux: Signal datapath that unaligned
 Netlink message can be received

Hello.

On 22-11-2013 0:52, Ben Pfaff wrote:

>>> Following commit (''netlink: Do not enforce alignment of last Netlink
>>> attribute''), signal the ability to receive unaligned Netlink messages
>>> to the datapath to enable utilization of zerocopy optimizations.

>>> Signed-off-by: Thomas Graf <tgraf@...hat.com>
>> [...]

>>> diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
>>> index 1dcf321..5c952bc 100644
>>> --- a/lib/dpif-linux.c
>>> +++ b/lib/dpif-linux.c
>> [...]
>>> @@ -1839,6 +1841,10 @@ dpif_linux_dp_to_ofpbuf(const struct dpif_linux_dp *dp, struct ofpbuf *buf)
>>>           nl_msg_put_u32(buf, OVS_DP_ATTR_UPCALL_PID, *dp->upcall_pid);
>>>       }
>>>
>>> +    if (dp->user_features) {
>>> +        nl_msg_put_u32(buf, OVS_DP_ATTR_USER_FEATURES, dp->user_features);
>>> +    }
>>> +
>>
>>     {} not needed here.

> This is Open vSwitch code,

    I didn't put much attention at the file name or subject but the issue 
seemed just too obvious...

> so it follows Open vSwitch coding style,
> which requires the {}.

    Strange style. Oh well... :-)

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html