netdev - Re: [PATCH net v3] bonding: disable arp and enable mii monitoring when bond change to no uses arp mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <528FB811.2010801@redhat.com>
Date:	Fri, 22 Nov 2013 21:01:21 +0100
From:	Nikolay Aleksandrov <nikolay@...hat.com>
To:	Ding Tianhong <dingtianhong@...wei.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Dan Williams <dcbw@...hat.com>,
	David Miller <davem@...emloft.net>
CC:	fubar@...ibm.com, vfalico@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v3] bonding: disable arp and enable mii monitoring
 when bond change to no uses arp mode

On 11/22/2013 03:28 PM, Ding Tianhong wrote:
> Because the ARP monitoring is not support for 802.3ad, but I still
> could change the mode to 802.3ad from ab mode while ARP monitoring
> is running, it is incorrect.
> 
> So add a check for 802.3ad in bonding_store_mode to fix the problem,
> and make a new macro BOND_NO_USES_ARP() to simplify the code.
> 
> v2: according to the Dan Williams's suggestion, bond mode is the most
>     important bond option, it should override any of the other sub-options.
>     So when the mode is changed, the conficting values should be cleared
>     or reset, otherwise the user has to duplicate more operations to modify
>     the logic. I disable the arp and enable mii monitoring when the bond mode
>     is changed to AB, TB and 8023AD if the arp interval is true.
> 
> v3: according to the Nik's suggestion, the default value of miimon should need
>     a name, there is several place to use it, and the bond_store_arp_interval()
>     could use micro BOND_NO_USES_ARP to make the code more simpify.
> 
> Suggested-by: Dan Williams <dcbw@...hat.com>
> Suggested-by: Nikolay Aleksandrov <nikolay@...hat.com>
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>
> ---

Reviewed-by: Nikolay Aleksandrov <nikolay@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html