netdev - Re: [PATCH 2/2] e1000: fix possible reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1385162041.2219.29.camel@jtkirshe-mobl>
Date:	Fri, 22 Nov 2013 15:14:01 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Vladimir Davydov <vdavydov@...allels.com>
Cc:	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, devel@...nvz.org,
	Tushar Dave <tushar.n.dave@...el.com>,
	Patrick McHardy <kaber@...sh.net>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 2/2] e1000: fix possible reset_task running after
 adapter down

On Fri, 2013-11-22 at 12:20 +0400, Vladimir Davydov wrote:
> On e1000_down(), we should ensure every asynchronous work is canceled
> before proceeding. Since the watchdog_task can schedule other works
> apart from itself, it should be stopped first, but currently it is
> stopped after the reset_task. This can result in the following race
> leading to the reset_task running after the module unload:
> 
> e1000_down_and_stop():                  e1000_watchdog():
> ----------------------                  -----------------
> 
> cancel_work_sync(reset_task)
>                                         schedule_work(reset_task)
> cancel_delayed_work_sync(watchdog_task)
> 
> The patch moves cancel_delayed_work_sync(watchdog_task) at the
> beginning
> of e1000_down_and_stop() thus ensuring the race is impossible.
> 
> Signed-off-by: Vladimir Davydov <vdavydov@...allels.com>
> Cc: Tushar Dave <tushar.n.dave@...el.com>
> Cc: Patrick McHardy <kaber@...sh.net>
> Cc: David S. Miller <davem@...emloft.net>
> ---
>  drivers/net/ethernet/intel/e1000/e1000_main.c |   15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)

I have applied your patch to my queue, thanks!

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)