netdev - Re: [PATCH] net: sched: tbf: fix an oops when a GSO packet cannot be enqueued

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1385229367.10637.92.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sat, 23 Nov 2013 09:56:07 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Yang Yingliang <yangyingliang@...wei.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, ben@...adent.org.uk,
	jpirko@...hat.com, jhs@...atatu.com
Subject: Re: [PATCH] net: sched: tbf: fix an oops when a GSO packet cannot
 be enqueued

On Sat, 2013-11-23 at 16:08 +0800, Yang Yingliang wrote:

> 
> I've applied this patch, but it's oops too.
> I think it's not the same problem. In this
> problem, when the segs is not enqueued, we do
> nothing to the segs.I think it causes the
> problem. If I am wrong, please point out.
> Thanks!
> 
> Here is the call trace after applying the above patch:
> BTW, the call trace is not always same no matter the
> above patch is applied.
> 

Oh right. Your patch on the right way, but changelog very confusing.

BTW, setting a mtu of 1KB on TBF never worked if your ethernet device
has MTU of 1500.

I think that we should emit a warning if TBF mtu is too low.

Ideally we should not even call skb_gso_segment() at all.

I'll post an updated version of the patch with a more detailed changelog
and explanations.

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html