netdev - Re: [1/2] gro: Only verify TCP checksums for candidates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131123.144714.582960796340864160.davem@davemloft.net>
Date:	Sat, 23 Nov 2013 14:47:14 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	herbert@...dor.apana.org.au, alexander.h.duyck@...el.com,
	alexander.duyck@...il.com, netdev@...r.kernel.org,
	edumazet@...gle.com
Subject: Re: [1/2] gro: Only verify TCP checksums for candidates

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 21 Nov 2013 21:55:12 -0800

> On Fri, 2013-11-22 at 10:31 +0800, Herbert Xu wrote:
>> In some cases we may receive IP packets that are longer than
>> their stated lengths.  Such packets are never merged in GRO.
>> However, we may end up computing their checksums incorrectly
>> and end up allowing packets with a bogus checksum enter our
>> stack with the checksum status set as verified.
>> 
>> Since such packets are rare and not performance-critical, this
>> patch simply skips the checksum verification for them.
>> 
>> Reported-by: Alexander Duyck <alexander.h.duyck@...el.com>
>> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
>> Acked-by: Alexander Duyck <alexander.h.duyck@...el.com>
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Appplied.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html