netdev - Re: [PATCH] inet: fix addr_len/msg->msg_namelen assignment in recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131123.144900.364271861197097555.davem@davemloft.net>
Date:	Sat, 23 Nov 2013 14:49:00 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, spender@...ecurity.net, mpb.mail@...il.com,
	eric.dumazet@...il.com
Subject: Re: [PATCH] inet: fix addr_len/msg->msg_namelen assignment in
 recv_error and rxpmtu functions

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Sat, 23 Nov 2013 00:46:12 +0100

> Commit bceaa90240b6019ed73b49965eac7d167610be69 ("inet: prevent leakage
> of uninitialized memory to user in recv syscalls") conditionally updated
> addr_len if the msg_name is written to. The recv_error and rxpmtu
> functions relied on the recvmsg functions to set up addr_len before.
> 
> As this does not happen any more we have to pass addr_len to those
> functions as well and set it to the size of the corresponding sockaddr
> length.
> 
> This broke traceroute and such.
> 
> Fixes: bceaa90240b6 ("inet: prevent leakage of uninitialized memory to user in recv syscalls")
> Reported-by: Brad Spengler <spender@...ecurity.net>
> Reported-by: Tom Labanowski
> Cc: mpb <mpb.mail@...il.com>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html