netdev - Re: [PATCH] sch_tbf: handle too small burst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131123.144933.671852794341688223.davem@davemloft.net>
Date:	Sat, 23 Nov 2013 14:49:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	yangyingliang@...wei.com, netdev@...r.kernel.org,
	ben@...adent.org.uk, jpirko@...hat.com, jhs@...atatu.com
Subject: Re: [PATCH] sch_tbf: handle too small burst

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 23 Nov 2013 12:59:20 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> If a too small burst is inadvertently set on TBF, we might trigger
> a bug in tbf_segment(), as 'skb' instead of 'segs' was used in a
> qdisc_reshape_fail() call.
> 
> tc qdisc add dev eth0 root handle 1: tbf latency 50ms burst 1KB rate
> 50mbit
> 
> Fix the bug, and add a warning, as such configuration is not
> going to work anyway for non GSO packets.
> 
> (For some reason, one has to use a burst >= 1520 to get a working
> configuration, even with old kernels. This is a probable iproute2/tc
> bug)
> 
> Based on a report and initial patch from Yang Yingliang
> 
> Fixes: e43ac79a4bc6 ("sch_tbf: segment too big GSO packets")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Yang Yingliang <yangyingliang@...wei.com>

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html