netdev - Re: [PATCH 3/5] ixgbe: Convert to use devm_hwmon_device_register_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1385421428.2270.15.camel@jtkirshe-mobl>
Date:	Mon, 25 Nov 2013 15:17:08 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>,
	Don Skidmore <donald.c.skidmore@...el.com>,
	Greg Rose <gregory.v.rose@...el.com>,
	Nithin Nayak Sujir <nsujir@...adcom.com>,
	Michael Chan <mchan@...adcom.com>,
	e1000-devel@...ts.sourceforge.net, lm-sensors@...sensors.org
Subject: Re: [PATCH 3/5] ixgbe: Convert to use
 devm_hwmon_device_register_with_groups

On Fri, 2013-11-22 at 22:07 -0800, Guenter Roeck wrote:
> Simplify the code. Attach hwmon sysfs attributes to hwmon device
> instead of pci device. Avoid race conditions caused by attributes
> being created after hwmon device registration. Implicitly
> (through hwmon API) add mandatory 'name' sysfs attribute.
> 
> Other cleanup:
> 
> Instead of allocating memory for hwmon attributes, move attributes
> and all other hwmon related data into struct hwmon_buff and allocate
> the entire structure using devm_kzalloc.
> 
> Check return value from calls to igb_add_hwmon_attr() one by one
> instead
> of logically combining them all together.
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h       |    8 ++-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.c |   76
> ++++++++++--------------
>  2 files changed, 36 insertions(+), 48 deletions(-)

I have added this to my queue, thanks!

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)