netdev - Re: [Pv-drivers] [PATCH] net: vmxnet3: remove unnecessary pci_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7790085.oo1KN3vePZ@dtor-d630.eng.vmware.com>
Date:	Wed, 27 Nov 2013 10:27:03 -0800
From:	Dmitry Torokhov <dtor@...are.com>
To:	pv-drivers@...are.com
Cc:	Jingoo Han <jg1.han@...sung.com>,
	"'David S. Miller'" <davem@...emloft.net>,
	'Aditya Sarwade' <asarwade@...are.com>, netdev@...r.kernel.org
Subject: Re: [Pv-drivers] [PATCH] net: vmxnet3: remove unnecessary pci_set_drvdata()

On Monday, November 25, 2013 11:05:23 AM Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>

Acked-by: Dmitry Torokhov <dtor@...are.com>

> ---
>  drivers/net/vmxnet3/vmxnet3_drv.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
> b/drivers/net/vmxnet3/vmxnet3_drv.c index 7e2788c..a300a18 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -3132,7 +3132,6 @@ err_alloc_queue_desc:
>  err_alloc_shared:
>  	dma_unmap_single(&adapter->pdev->dev, adapter->adapter_pa,
>  			 sizeof(struct vmxnet3_adapter), PCI_DMA_TODEVICE);
> -	pci_set_drvdata(pdev, NULL);
>  	free_netdev(netdev);
>  	return err;
>  }

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html