netdev - Re: [PATCH net-next 7/8] openvswitch: Drop user features if old user space attempted to create datapath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131127223512.GB26084@casper.infradead.org>
Date:	Wed, 27 Nov 2013 22:35:12 +0000
From:	Thomas Graf <tgraf@...g.ch>
To:	Jesse Gross <jesse@...ira.com>
Cc:	David Miller <davem@...emloft.net>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>,
	netdev <netdev@...r.kernel.org>,
	Daniel Borkmann <dborkman@...hat.com>, ffusco@...hat.com,
	fleitner@...hat.com, Eric Dumazet <eric.dumazet@...il.com>,
	Ben Hutchings <bhutchings@...arflare.com>
Subject: Re: [PATCH net-next 7/8] openvswitch: Drop user features if old user
 space attempted to create datapath

On 11/25/13 at 03:40pm, Jesse Gross wrote:
> On Fri, Nov 22, 2013 at 8:56 AM, Thomas Graf <tgraf@...g.ch> wrote:
> > diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h
> > index 07ef2c3..a6863e2 100644
> > --- a/include/uapi/linux/openvswitch.h
> > +++ b/include/uapi/linux/openvswitch.h
> > @@ -40,7 +40,15 @@ struct ovs_header {
> >
> >  #define OVS_DATAPATH_FAMILY  "ovs_datapath"
> >  #define OVS_DATAPATH_MCGROUP "ovs_datapath"
> > -#define OVS_DATAPATH_VERSION 0x1
> > +
> > +/* V2:
> > + *   - API users are expected to provide OVS_DP_ATTR_USER_FEATURES
> > + *     with NLM_F_REPLACE when creating the datapath.
> > + */
> > +#define OVS_DATAPATH_VERSION 2
> 
> I'm not sure that I understand this comment - I guess it means that
> there's no legacy path when using NLM_F_REPLACE?

It means that if the V2 caller does not provide user features the
existing user features are preserved upon NLM_F_REPLACE. V1 users
can't be aware and the user features are always reset.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html