netdev - Re: [PATCH] genetlink: Fix uninitialized variable in genl_validate_assign_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131128.182505.1593147138692009632.davem@davemloft.net>
Date:	Thu, 28 Nov 2013 18:25:05 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	geert@...ux-m68k.org
Cc:	johannes.berg@...el.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] genetlink: Fix uninitialized variable in
 genl_validate_assign_mc_groups()

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Sat, 23 Nov 2013 13:01:50 +0100

> net/netlink/genetlink.c: In function ‘genl_validate_assign_mc_groups’:
> net/netlink/genetlink.c:217: warning: ‘err’ may be used uninitialized in this
> function
> 
> Commit 2a94fe48f32ccf7321450a2cc07f2b724a444e5b ("genetlink: make multicast
> groups const, prevent abuse") split genl_register_mc_group() in multiple
> functions, but dropped the initialization of err.
> 
> Initialize err to zero to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> Question: Is the for_each_net_rcu() loop in genl_validate_assign_mc_groups()
>           guaranteed to loop at least once?
> 	  If yes, this is a false positive.

Applied, but yes it's a false positive.  There is always &init_net so the
loop always iterates at least once.