netdev - RE: [PATCH net] r8169: check ALDPS bit and disable it if enabledforthe 8168g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3D20A16DBE2E409ABD3A208B40879CC5@realtek.com.tw>
Date:	Thu, 28 Nov 2013 15:58:53 +0800
From:	hayeswang <hayeswang@...ltek.com>
To:	'David Chang' <dchang@...e.com>
CC:	<netdev@...r.kernel.org>,
	"'David S. Miller'" <davem@...emloft.net>,
	'Francois Romieu' <romieu@...zoreil.com>, <jlee@...e.com>,
	'nic_swsd' <nic_swsd@...ltek.com>
Subject: RE: [PATCH net] r8169: check ALDPS bit and disable it if enabledforthe 8168g

 David Chang [mailto:dchang@...e.com] 
> Sent: Thursday, November 28, 2013 2:23 PM
> To: Hayeswang
> Cc: netdev@...r.kernel.org; 'David S. Miller'; 'Francois 
> Romieu'; jlee@...e.com; nic_swsd
> Subject: Re: [PATCH net] r8169: check ALDPS bit and disable 
> it if enabledforthe 8168g
> 
> On Thu, Nov 28, 2013 at 01:28:08PM +0800, hayeswang wrote:
> >  David Chang [mailto:dchang@...e.com] 
> > > Sent: Thursday, November 28, 2013 12:29 PM
> > > To: Hayeswang
> > > Cc: netdev@...r.kernel.org; 'David S. Miller'; 'Francois 
> > > Romieu'; jlee@...e.com; nic_swsd
> > > Subject: Re: [PATCH net] r8169: check ALDPS bit and disable 
> > > it if enabled forthe 8168g
> > [...]
> > > > You have to delay at least 10 ms after disable it.
> > > > This makes sure the hw completes the action.
> > > >  
> > > 
> > > Thanks for your comment. 
> > > I'd add a delay time and send the v2 version.
> > 
> > Excuse me. Our engineers have different opinions about the delay.
> > I would comfirm it first.
> >  
> OK! I'd wait until the final result, thanks!

The delay is unnecessary. Thanks.

Acked-by: Hayes Wang <hayeswang@...ltek.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html