netdev - Re: [PATCH net] diag: fix netlink API attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131128163816.GA32047@casper.infradead.org>
Date:	Thu, 28 Nov 2013 16:38:16 +0000
From:	Thomas Graf <tgraf@...g.ch>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] diag: fix netlink API attributes

On 11/28/13 at 02:57pm, Nicolas Dichtel wrote:
> The first netlink attribute (value 0) must always be defined as none/unspec.
> This is correctly done in inet_diag.h, but other diag interfaces are broken.
> 
> Libraries like libnl skip this kind of attributes, thus it's never reported to
> the application.
> 
> CC: Thomas Graf <tgraf@...g.ch>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

First of all, thanks for the notification Nicolas. I'll fix libnl to
pass through these attributes.

I think the fix you propose is no an option as it breaks backwards
compatiblity with existing user space. We cannot change the value
of existing attributes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html