netdev - Re: [PATCH v2 04/17] net: bnx2x calls skb_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131129.154312.1641973884966551317.davem@davemloft.net>
Date:	Fri, 29 Nov 2013 15:43:12 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 04/17] net: bnx2x calls skb_set_rxhash

From: Tom Herbert <therbert@...gle.com>
Date: Tue, 26 Nov 2013 09:22:54 -0800 (PST)

> -		skb->rxhash = tpa_info->rxhash;
> -		skb->l4_rxhash = tpa_info->l4_rxhash;
> +		skb_set_rxhash(skb, tpa_info->rxhash,
> +		    tpa_info->l4_rxhash ? RXHASH_TYPE_L4 : RXHASH_TYPE_L3);
 ...
> -		skb->rxhash = bnx2x_get_rxhash(bp, cqe_fp, &l4_rxhash);
> -		skb->l4_rxhash = l4_rxhash;
> +		rxhash = bnx2x_get_rxhash(bp, cqe_fp, &l4_rxhash);
> +		skb_set_rxhash(skb, rxhash,
> +			       l4_rxhash ? RXHASH_TYPE_L4 : RXHASH_TYPE_L3);

Inconsistent indentation, the second one is correct the first one is
not.

Please audit this in your entire patch set, there are few other
instances.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html