netdev - Re: [PATCH v2 net] af_packet: block BH in prb_shutdown_retire_blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131129.161157.1747355120800232114.davem@davemloft.net>
Date:	Fri, 29 Nov 2013 16:11:57 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dborkman@...hat.com
Cc:	vfalico@...hat.com, netdev@...r.kernel.org, jstancek@...hat.com,
	willemb@...gle.com, phil@....cc, edumazet@...gle.com
Subject: Re: [PATCH v2 net] af_packet: block BH in
 prb_shutdown_retire_blk_timer()

From: Daniel Borkmann <dborkman@...hat.com>
Date: Fri, 29 Nov 2013 10:19:29 +0100

> On 11/29/2013 09:53 AM, Veaceslav Falico wrote:
>> Currently we're using plain spin_lock() in
>> prb_shutdown_retire_blk_timer(),
>> however the timer might fire right in the middle and thus try to
>> re-aquire
>> the same spinlock, leaving us in a endless loop.
>>
>> To fix that, use the spin_lock_bh() to block it.
>>
>> CC: "David S. Miller" <davem@...emloft.net>
>> CC: Daniel Borkmann <dborkman@...hat.com>
>> CC: Willem de Bruijn <willemb@...gle.com>
>> CC: Phil Sutter <phil@....cc>
>> CC: Eric Dumazet <edumazet@...gle.com>
>> Reported-by: Jan Stancek <jstancek@...hat.com>
>> Tested-by: Jan Stancek <jstancek@...hat.com>
>> Signed-off-by: Veaceslav Falico <vfalico@...hat.com>
> 
> Fixes: f6fb8f100b80 ("af-packet: TPACKET_V3 flexible buffer
> implementation.")
> Acked-by: Daniel Borkmann <dborkman@...hat.com>

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html