netdev - Re: [PATCH v2] net: 8139cp: fix a BUG_ON triggered by wrong bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131129.161920.119393762714075664.davem@davemloft.net>
Date:	Fri, 29 Nov 2013 16:19:20 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	yangyingliang@...wei.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	dwmw2@...radead.org, dave.taht@...ferbloat.net
Subject: Re: [PATCH v2] net: 8139cp: fix a BUG_ON triggered by wrong
 bytes_compl

From: Yang Yingliang <yangyingliang@...wei.com>
Date: Wed, 27 Nov 2013 14:32:52 +0800

> From: Yang Yingliang <yangyingliang@...wei.com>
> 
> Using iperf to send packets(GSO mode is on), a bug is triggered:
 ...
> When a skb has frags, bytes_compl plus skb->len nr_frags times in cp_tx().
> It's not the correct value(actually, it should plus skb->len once) and it
> will trigger the BUG_ON(bytes_compl > num_queued - dql->num_completed).
> So only increase bytes_compl when finish sending all frags. pkts_compl also
> has a wrong value, fix it too.
> 
> It's introduced by commit 871f0d4c("8139cp: enable bql").
> 
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html