netdev - Re: [PATCH v2] inet: fix possible seqlock deadlocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131129.163813.2060324714200934714.davem@davemloft.net>
Date:	Fri, 29 Nov 2013 16:38:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	eric.dumazet@...il.com, jongman.heo@...sung.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] inet: fix possible seqlock deadlocks

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Thu, 28 Nov 2013 19:09:14 +0100

> On Thu, Nov 28, 2013 at 09:51:22AM -0800, Eric Dumazet wrote:
>> From: Eric Dumazet <edumazet@...gle.com>
>> 
>> In commit c9e9042994d3 ("ipv4: fix possible seqlock deadlock") I left
>> another places where IP_INC_STATS_BH() were improperly used.
>> 
>> udp_sendmsg(), ping_v4_sendmsg() and tcp_v4_connect() are called from
>> process context, not from softirq context.
>> 
>> This was detected by lockdep seqlock support.
>> 
>> Reported-by: jongman heo <jongman.heo@...sung.com>
>> Fixes: 584bdf8cbdf6 ("[IPV4]: Fix "ipOutNoRoutes" counter error for TCP and UDP")
>> Fixes: c319b4d76b9e ("net: ipv4: add IPPROTO_ICMP socket kind")
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> Cc: Hannes Frederic Sowa <hannes@...essinduktion.org>
> 
> Just got home after getting distracted with other things today and the work is
> already done. Thanks, Eric! ;)
> 
> Exactly the spots I noticed this morning, so
> 
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html