netdev - Re: [[PATCH stable <3.12]] xen-netback: fix refcnt unbalance for 3.11 and earlier versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131130.161911.986012805406716752.davem@davemloft.net>
Date:	Sat, 30 Nov 2013 16:19:11 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	wei.liu2@...rix.com
Cc:	Ian.Campbell@...rix.com, xen-devel@...ts.xen.org,
	netdev@...r.kernel.org, stable@...r.kernel.org,
	tomasz.wroblewski@...rix.com, konrad.wilk@...cle.com,
	david.vrabel@...rix.com
Subject: Re: [[PATCH stable <3.12]] xen-netback: fix refcnt unbalance for
 3.11 and earlier versions

From: Wei Liu <wei.liu2@...rix.com>
Date: Thu, 28 Nov 2013 13:13:46 +0000

> On Thu, Nov 28, 2013 at 01:08:53PM +0000, Ian Campbell wrote:
>> On Thu, 2013-11-28 at 12:48 +0000, Wei Liu wrote:
>> > With the introduction of "xen-netback: Don't destroy the netdev until
>> > the vif is shut down" (upstream commit id 279f438e36), vif disconnect
>> > and free are separated. However in the backported verion reference
>> > counting code was not correctly modified, and the reset of vif->tx_irq
>> > was lost. If frontend goes through vif life cycle more than once the
>> > reference counting is skewed.
>> > 
>> > This patch adds back the missing tx_irq reset line. It also moves
>> > several lines of the reference counting code to vif_free, so the moved
>> > code corresponds to the counterpart in vif_alloc, thus the reference
>> > counting is balanced.
>> 
>> Is this a requirement of the bugfix or just to make reasoning about
>> things easier?
>> 
> 
> The latter.

I've queued this up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html