netdev - Re: [PATCH net] net: neighbour: make sure the handler has finished before kfree neighbour

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <529AA23E.8040306@gmail.com>
Date:	Sun, 01 Dec 2013 10:43:10 +0800
From:	Ding Tianhong <dthxman@...il.com>
To:	David Miller <davem@...emloft.net>
CC:	dingtianhong@...wei.com, gaofeng@...fujitsu.com,
	yoshfuji@...ux-ipv6.org, joe@...ches.com, vfalico@...hat.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net] net: neighbour: make sure the handler has finished
 before kfree neighbour

于 2013/12/1 5:27, David Miller 写道:
> From: Ding Tianhong <dingtianhong@...wei.com>
> Date: Thu, 28 Nov 2013 20:28:52 +0800
> 
>> I have met the oops in Suse11 SP2, the kernel is 2.6.32.59-0.7-default:
> 
> This doesn't make any sense.
> 
> If this actually was the reason, then del_timer() would have returned true,
> and thus neigh_del_timer() would have returned "1" and you would have
> seen the "Impossible event" log message that neigh_destroy() prints out.
> 
> You may think the cause is a pending timer, but the data you've provided
> does not support this at all.
> 
> And if it isn't happening, your patch removing that warning is wrong.
> 
> Furthermore, if this change to use del_timer_sync() is correct, it
> probably belongs in neigh_del_timer() because all of it's other callers
> expect the timer to not be running and that all references to the object
> are stable after such calls.
> 
> I'm not applying this, you really need to pursue this bug fix more
> cleanly and more thoroughly because it's a non-trivial issue.
> 
> Thanks.

ok，thanks for the advice, I would like to think it over and make it better.

Regards
Ding

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html