netdev - Re: gem csum breakage with 018c5bba (Handle CHECKSUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131202.135902.408377838919681103.davem@davemloft.net>
Date:	Mon, 02 Dec 2013 13:59:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	agraf@...e.de
Cc:	herbert@...dor.apana.org.au, alexander.h.duyck@...el.com,
	netdev@...r.kernel.org, edumazet@...gle.com,
	herbert@...dor.apana.org, linux-kernel@...r.kernel.org,
	benh@...nel.crashing.org
Subject: Re: gem csum breakage with 018c5bba (Handle CHECKSUM_COMPLETE more
 adequately ...)

From: Alexander Graf <agraf@...e.de>
Date: Fri, 22 Nov 2013 19:08:16 +0100

> With current Linus' master tree my ibook started emitting a lot of
> annoying csum calculation warnings. I've bisected it down to the
> commit seen in the subject line, but I suppose the real problem lies
> somewhere a lot deeper and only gets revealed thanks to the more
> clever checksum logic applied now.
> 
> Any ideas how to dig further into this?

Ok, I'm going to revert this commit, for several reasons.

In addition to the problem you are running into, it just occurred to me
that if the __pskb_trim() call fails, we'll leave a corrupted checksum
in the SKB.

Thanks for your report.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html