netdev - Re: [PATCH 2/2] net: emaclite: add barriers to support Xilinx Zynq platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131201.200906.25118738399177322.davem@davemloft.net>
Date:	Sun, 01 Dec 2013 20:09:06 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	srikanth.thokala@...inx.com
Cc:	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	michal.simek@...inx.com, sthokal@...inx.com
Subject: Re: [PATCH 2/2] net: emaclite: add barriers to support Xilinx Zynq
 platform

From: Srikanth Thokala <srikanth.thokala@...inx.com>
Date: Thu, 28 Nov 2013 12:59:57 +0530

> This patch adds barriers at appropriate places to ensure the driver
> works on Xilinx Zynq ARM-based SoC platform.
> 
> Signed-off-by: Srikanth Thokala <sthokal@...inx.com>

Memory barriers must have comments.

Specifically, the comment must describe what exactly is being ensured
by the memory barrier.  What entity must see what memory operations in
what order?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html