netdev - Re: [PATCH] rds: prevent BUG_ON triggered on congestion update to loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131201.201930.2009545384899801860.davem@davemloft.net>
Date:	Sun, 01 Dec 2013 20:19:30 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	venkat.x.venkatsubra@...cle.com
Cc:	rds-devel@....oracle.com, netdev@...r.kernel.org, honli@...hat.com,
	joshhunt00@...il.com, bang.nguyen@...cle.com
Subject: Re: [PATCH] rds: prevent BUG_ON triggered on congestion update to
 loopback

From: Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>
Date: Mon, 25 Nov 2013 09:47:34 +0300

> From: Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>
> 
> After congestion update on a local connection, when rds_ib_xmit returns
> less bytes than that are there in the message, rds_send_xmit calls
> back rds_ib_xmit with an offset that causes BUG_ON(off & RDS_FRAG_SIZE)
> to trigger.
> 
> Reported-by: Josh Hunt <joshhunt00@...il.com>
> Tested-by: Honggang Li <honli@...hat.com>
> Acked-by: Bang Nguyen <bang.nguyen@...cle.com>
> Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks Venkat, this is almost perfect.

Please adjust the commit message so that it contains all of the analysis
you posted before.  You can never include too much information, especially
for a fix for a bug that languished for such a long time like this one
did.  In particular you should mentioned the ppc bug fix that introduced
this regression, reference such commits in the following format:

	$SHA1_ID ("Commit message header text")

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html