netdev - Re: [PATCH v2 1/2] virtio_net: fix error handling for mergeable buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131201.202752.1283570881734672398.davem@davemloft.net>
Date:	Sun, 01 Dec 2013 20:27:52 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mst@...hat.com
Cc:	linux-kernel@...r.kernel.org, rusty@...tcorp.com.au,
	mwdalton@...gle.com, edumazet@...gle.com, jasowang@...hat.com,
	virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/2] virtio_net: fix error handling for mergeable
 buffers

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Thu, 28 Nov 2013 13:30:55 +0200

> Eric Dumazet noticed that if we encounter an error
> when processing a mergeable buffer, we don't
> dequeue all of the buffers from this packet,
> the result is almost sure to be loss of networking.
> 
> Jason Wang noticed that we also leak a page and that we don't decrement
> the rq buf count, so we won't repost buffers (a resource leak).
> 
> Fix both issues.
> 
> Cc: Rusty Russell <rusty@...tcorp.com.au>
> Cc: Michael Dalton <mwdalton@...gle.com>
> Reported-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Jason Wang <jasowang@...hat.com>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html